test: unit test fixes for jest 29.5 #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use mockImplementation instead of mockReset on Jest spy mock. The jest implementation has changed, and mockReset no longer sets an empty mock function on spy mocks. * Update the snapshots for the e2e enum tests. A line number in the stack traces has changed. * Update the caniuse-lite version. browserlist was writing a 'Browserslist: caniuse-lite is outdated...' message to stderr, which caused parsing of jest output to fail in the e2e transform-js test.
|
Note that I made this PR against the existing renovate/jest-packages branch. If merged into that branch, it should fix the unit tests that are currently failing for #3979. I thought that would be better than losing or trying to reproduce the description included in that MR. |
For isolated and esm example tests, the jest config specified multiple transforms to match .ts and .tsx files. This accidentally worked because if multiple regex blocks specified the same preprocessor (e.g., 'ts-jest'), then the last one would clobber the options set by earlier ones. This behavior was recently fixed in jest, which broke these tests.
|
Pushed another commit to fix test-examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some minor changes that will allow the jest 29.5 updates in #3979 to pass unit tests:
^.+\\.(ts|tsx)$and^.+\\.tsx?$). Only the second one specified the necessary options to ts-jest for ESM and isolated configurations. This only worked because jest stored options per-transform-script and not per-regex. That changed in a recent fix, which broke these tests.Summary
Test plan
Does this PR introduce a breaking change?
Other information