Module warning => message not throwing #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostics have a category. By default if warnOnly is not set, when diagnostic(s) of kind message or suggestion will be raised, ts-jest will log it but not throw. This also changes the category of the internal TS151000. Closes kulshekhar#748
Pull Request Test Coverage Report for Build 1890
💛 - Coveralls |
5 tasks
kulshekhar
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #748 by emitting a message without throwing in case module kind is not compatible with
commonjsand neitheresModuleInteropnorallowSyntheticDefaultImportsis set.FYI we must enforce
commonjsmodule as Jest relies on it.revieweer(s): only source file changed: src/config/config-set.ts – others are unit and e2e tests, with a snapshot for each module-kind/import modifiers config options