Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preset typings #794

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Fix preset typings #794

merged 2 commits into from
Oct 6, 2018

Conversation

huafu
Copy link
Collaborator

@huafu huafu commented Oct 6, 2018 •
edited

  • invalid import in ts-jest/presets typings
  • typos in ts-jest/presets typings (thanks @evpozdniakov)
  • added tests for this to not reproduce, as well as tests for utils. Added tests also ensure it works with whatever values for esModuleInterop or allowSyntheticDefaultImports

reviewer(s): last file in Files changed tab is the only one that matters, others are tests & their snapshots

@huafu huafu mentioned this pull request Oct 6, 2018
Closed
@huafu huafu added this to the 23.10.4 milestone Oct 6, 2018
@huafu huafu added the hotfix label Oct 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1978

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.919%
Totals Coverage Status
Change from base Build 1976: 0.0%
Covered Lines: 1088
Relevant Lines: 1138
💛 - Coveralls

@huafu huafu merged commit 69b80ad into kulshekhar:master Oct 6, 2018
@huafu huafu deleted the fix-preset-typings branch October 6, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.10.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huafu @coveralls @kulshekhar @evpozdniakov