Fix dependencies #978
Merged
Fix dependencies #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Pull Request Test Coverage Report for Build 2379
💛 - Coveralls |
|
@huafu @kulshekhar I'd love if one of you could merge this in. |
|
Thanks for fixing this! I'm wondering whether this is what caused tests on AppVeyor to fail for the Jest 24 PR. |
kulshekhar
approved these changes
Feb 16, 2019
|
It might have been, it's definitely what's been causing all the dependabot tests to fail :) |
|
observe today that Travis failed due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we've managed to break master in some interesting ways.
Due to symlink issues on Windows, it was actually impossible to get the tests running locally, and we had a tslint rule failing on master, which is why a lot of the Dependabot PR's were failing.
I've fixed the windows symlink issues, and updated all major dependencies, except for jest 24, which I'll leave to #957