Add ability to resolve "extends" directive in tsconfig.json #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis breaks for some other reason I think..? |
|
@emilniklas Thanks for the PR!. Yes, there's an issue open about randomly failing CI tests - #89 The PR looks good to me barring the small change I've suggested |
kulshekhar
requested changes
Jan 18, 2017
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Wouldn't it be better to use constants from typescript that represent each of these values instead of numbers?
|
@kulshekhar Okay! I just copied the test above. I'll go in and change it everywhere. |
kulshekhar
approved these changes
Jan 18, 2017
|
Thanks again @emilniklas 😄 |
|
@kulshekhar any idea when this will get released? |
kulshekhar
added a commit
that referenced
this pull request
Jan 25, 2017
to publish changes merged in #98
Merged
|
@wmonk done! |
|
Woohoo, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#configuration-inheritance-with-extends