Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dataplaneTokenPath field from Envoy node metadata into dataplane.token.filename #512

Closed
yskopets opened this issue Dec 23, 2019 · 3 comments
Closed

Rename dataplaneTokenPath field from Envoy node metadata into dataplane.token.filename #512

yskopets opened this issue Dec 23, 2019 · 3 comments
Labels
area/kuma-cp breaking-change good first issue Good for newcomers kind/cleanup Cleanup/refactor an existing component/code triage/rotten closed due to lack of information for too long, rejected feature...

Comments

@yskopets
Copy link
Contributor

Summary

  • rename dataplaneTokenPath field from Envoy node metadata into dataplane.token.filename
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 15, 2021
@tharun208
feat(kuma-dp) rename tokenPath metadata field name
71f09ad 
renamed dataplaneTokenPath to dataplane.token.filename in envoy metadata

Fix kumahq#512

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208 tharun208 mentioned this issue Jan 15, 2021
Closed
1 task
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 15, 2021
@tharun208
feat(kuma-dp) rename tokenPath metadata field name
a836501 
renamed dataplaneTokenPath to dataplane.token.filename in envoy metadata

Fix kumahq#512

Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 19, 2021
@tharun208
feat(kuma-dp) rename tokenPath metadata field name
8c45045 
renamed dataplaneTokenPath to dataplane.token.filename in envoy metadata
added backward compatibility

Fix kumahq#512

Signed-off-by: Tharun <rajendrantharun@live.com>
@lahabana lahabana added kind/cleanup Cleanup/refactor an existing component/code area/kuma-cp breaking-change triage/pending This issue will be looked at on the next triage meeting and removed technical-debt labels Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 31, 2021
@jakubdyszkiewicz
Copy link
Contributor

We don't even have such fields now!

@jakubdyszkiewicz jakubdyszkiewicz added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/pending This issue will be looked at on the next triage meeting triage/stale Inactive for some time. It will be triaged again labels Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Automatically closing the issue due to having one of the "closed state label".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kuma-cp breaking-change good first issue Good for newcomers kind/cleanup Cleanup/refactor an existing component/code triage/rotten closed due to lack of information for too long, rejected feature...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kuma-dp) rename tokenPath metadata field name tharun208/kuma
3 participants
@lahabana @jakubdyszkiewicz @yskopets