feat(kuma-dp) rename tokenPath metadata field name #1427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharun208
force-pushed
the
feat/rename_dp_token_path_metdata_name
branch
from
71f09ad
to
a836501
Compare
jakubdyszkiewicz
requested changes
Jan 18, 2021
| @@ -16,7 +16,7 @@ var metadataLog = core.Log.WithName("xds-server").WithName("metadata-tracker") | |||
| const ( | |||
| // Supported Envoy node metadata fields. | |||
|
|
|||
| fieldDataplaneTokenPath = "dataplaneTokenPath" | |||
| fieldDataplaneTokenPath = "dataplane.token.filename" | |||
There was a problem hiding this comment.
This change has to be backward compatible.
When CP uses this field, it should also support the old field
There was a problem hiding this comment.
You mean this will break the deployed kuma-dp's that already are preconfigured with the old name?
renamed dataplaneTokenPath to dataplane.token.filename in envoy metadata added backward compatibility Fix kumahq#512 Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208
force-pushed
the
feat/rename_dp_token_path_metdata_name
branch
from
a836501
to
8c45045
Compare
tharun208
commented
Mar 8, 2021
| @@ -67,6 +67,9 @@ func DataplaneMetadataFromXdsMetadata(xdsMetadata *_struct.Struct) *DataplaneMet | |||
| if xdsMetadata == nil { | |||
| return &metadata | |||
| } | |||
| if field := xdsMetadata.Fields["dataplaneTokenPath"]; field != nil { | |||
There was a problem hiding this comment.
@jakubdyszkiewicz does this change look's okay for backward compatibility ?.
|
Thanks for the contribution and sorry for super late response. We don't use this field anymore, it was used for backward compatibility. It can be removed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed
dataplaneTokenPathtodataplane.token.filenamein envoy metadataFix #512
Signed-off-by: Tharun rajendrantharun@live.com