Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meshpassthrough): add support for delegated gateway #10675

Merged
merged 7 commits into from
Jul 4, 2024
Merged

feat(meshpassthrough): add support for delegated gateway #10675

merged 7 commits into from
Jul 4, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jun 28, 2024 •
edited
Loading

Checklist prior to review

  • Added support for MeshGateway in a delegated mode
  • Added E2E test for delegated gateway
  • Added appending domains with a port and adding them to the domains. Based on the RFC host header might have a port at the end if it's not 80/443.

@lukidzi
feat(meshpassthrough): add support for delegated gateway and add anot…
4e233a3 
…her domain with port value

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
delay requests execution
76810da 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
fix check
d795b94 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review July 1, 2024 07:20
@lukidzi lukidzi requested a review from a team as a code owner July 1, 2024 07:20
@lukidzi lukidzi requested review from slonka and lobkovilya and removed request for a team July 1, 2024 07:20
@lukidzi
move error check
d1488ed 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
use proxypatch
f342d38 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
add a comment
4e0c496 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from lobkovilya July 2, 2024 07:13
slonka
slonka reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Qs

pkg/plugins/policies/meshpassthrough/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshpassthrough/plugin/xds/listeners_filter_chain.go Show resolved Hide resolved
test/e2e_env/kubernetes/gateway/delegated/meshpassthrough.go Show resolved Hide resolved
@lukidzi
review
cab1da6 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from slonka July 3, 2024 07:32
slonka
slonka approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@lukidzi lukidzi merged commit 6c44719 into kumahq:master Jul 4, 2024
16 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@slonka slonka slonka approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshPassthrough policy support for Delegated MeshGateway
4 participants
@lukidzi @lahabana @slonka @lobkovilya