chore(*) customizable rootCmd in binaries and helm e2e #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2020 15:01
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Nov 19, 2020
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
* chore(*) unify binaries rootCmd handling * test(*) e2e testing framework for Helm robustness and customization Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 052c283)
nickolaev
pushed a commit
that referenced
this pull request
Nov 19, 2020
* chore(*) unify binaries rootCmd handling * test(*) e2e testing framework for Helm robustness and customization Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 052c283) Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unify the rootCmd creation in all our binaries.
Helm e2e customization.
Documentation