Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp) handle mesh delete more gracefully #1185

Merged
merged 2 commits into from
Nov 23, 2020
Merged

chore(kuma-cp) handle mesh delete more gracefully #1185

merged 2 commits into from
Nov 23, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Two things

  • Mesh resyncer was reacting on Mesh and MeshInsights events. That results in error messages when Mesh was deleted
  • Mesh reconciller is executing MeshManager#Delete to delete secrets. Ideally, we should remove it completely and rely on ownership of secrets that we need to build (described Set owners for Secrets #1137 ). Ignoring ErrorResourceNotFound should be enough for now.

Documentation

  • Internal fixes

@jakubdyszkiewicz
chore(kuma-cp) handle mesh delete more gracefully
69c9ba4 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner November 20, 2020 11:23
@jakubdyszkiewicz
fix delete even inmemory and handle mesh not found error
913fba9 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit e88f7e5 into master Nov 23, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/mesh-delete branch November 23, 2020 13:49
mergify bot pushed a commit that referenced this pull request Nov 23, 2020
@jakubdyszkiewicz
chore(kuma-cp) handle mesh delete more gracefully (#1185)
1c389d3 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit e88f7e5)
@mergify mergify bot mentioned this pull request Nov 23, 2020
Merged
nickolaev pushed a commit that referenced this pull request Nov 23, 2020
@mergify @jakubdyszkiewicz
chore(kuma-cp) handle mesh delete more gracefully (#1185) (#1197)
74274f5 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit e88f7e5)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubdyszkiewicz @nickolaev @lobkovilya