chore(*) better handling of SAN mismatch when DP connects to the CP #1205
Conversation
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
| @@ -292,10 +294,11 @@ var _ = Describe("bootstrapGenerator", func() { | |||
|
|
|||
| // given | |||
| params := bootstrap_config.DefaultBootstrapParamsConfig() | |||
| params.XdsHost = "127.0.0.1" | |||
| params.XdsHost = "localhost" | |||
There was a problem hiding this comment.
Please note that localhost does not resolve always to 127.0.0.1. For example:
$ uname -a
Darwin ............ 19.6.0 Darwin Kernel Version 19.6.0: Thu Oct 29 22:56:45 PDT 2020; root:xnu-6153.141.2.2~1/RELEASE_X86_64 x86_64
$ curl -vv localhost:80
* Trying ::1...
* TCP_NODELAY set
* Connection failed
* connect to ::1 port 80 failed: Connection refused
* Trying 127.0.0.1...
* TCP_NODELAY set
* Connection failed
* connect to 127.0.0.1 port 80 failed: Connection refused
* Failed to connect to localhost port 80: Connection refused
* Closing connection 0
curl: (7) Failed to connect to localhost port 80: Connection refused
There was a problem hiding this comment.
Yup, that's true. The cert we were using for tests had localhost not 127.0.0.1 therefore I thought it was easier to change it here. We are not resolving localhost to 127.0.0.1 in this test.
pkg/xds/bootstrap/generator.go
Outdated
| @@ -176,6 +224,14 @@ func (b *bootstrapGenerator) generateFor(proxyId core_xds.ProxyId, dataplane *co | |||
| return b.configForParameters(params) | |||
| } | |||
|
|
|||
| func (b *bootstrapGenerator) xdsHost(request types.BootstrapRequest) string { | |||
| if b.config.XdsHost != "" { | |||
There was a problem hiding this comment.
Why is it possible to return value from config if the idea is to validate request?
There was a problem hiding this comment.
because config takes precedence over request in case you want to override the XDS Host
There was a problem hiding this comment.
But the fact that b.config.XdsHost satisfies SANs should be validated somewhere in the config validation. You shouldn't allow kuma-cp to start if certificates don't have SAN for XdsHost, right? It's not a problem of a bootstrap client which sent the request
There was a problem hiding this comment.
Ok, changed validation to "constructor"
…smatch-on-cp-dp Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…smatch-on-cp-dp Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Summary
We autogenerate certificates with SANs of all IPs and hostnames from the machine. When CP starts we were warning in logs that we are autogenerating certificates and you can connect with the following addresses. That was not enough, Envoy was not helping with error msgs of
gRPC error code 13. This PR introduces more graceful handling of this problem. We can check the host and SAN certs when DP is asking for the bootstrap config. If there is mismatch, we are printing the following message:It works even if there is an initial mismatch between SAN and
--cp-addressbecause kuma-dp by default does not verify CP cert against CA (only on universal, we print warning msg) therefore this request will pass.Documentation