fix(kuma-cp) do not replace autogenerated certs #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
|
Making |
nickolaev
approved these changes
Nov 27, 2020
…enerated-secret Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit dc26d88) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Nov 30, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem
We were overriding autogenerated certs on Kubernetes therefore you need to restart the pods between upgrades.
The solution
Preserve autogenerated certificates between Kuma upgrades.
HELM
That was tricky. There is no native way to do it in HELM as the issue https://github.com/helm/charts/issues/5167 is still open, but there is a working workaround: read the secret if already exist and take the values from the secret. We cannot just do the
if is upgrade don't render secret, because if we don't render the secret it will be deleted.kumactl
Kumactl uses HELM under the hood to render YAML. Previously we did not require connection to the Kubernetes to render the YAML which was convenient. The
lookupfunction just returnsnilif you useRenderinstead ofRenderWithClient, but we want to have the same behavior as in HELM. To do it,kumactlnow requires connection to Kubernetes to check the state of secrets and now override them.Alternative solutions
We could introduce something like
initialSetupin Values.yaml and instruct the user to set this to false when installing for the first time + use"helm.sh/resource-policy": keep, but then we won't clean this secret on delete.On
kumactlwe could haveinstallandupgrade, but I think it's much easier to have this in one command.Full changelog
app/kumactl/pkg/k8s. It was from the early days of Kuma.install dnsandinstall control-planeDocumentation