Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp) generate stable EDS config #1228

Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix(kuma-cp) generate stable EDS config #1228

merged 2 commits into from
Nov 30, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

We did not sort the EDS config which resulted in unnecessary XDS traffic.

Documentation

  • No docs

@jakubdyszkiewicz
fix(kuma-cp) generate stable EDS config
9f26b2f 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner November 27, 2020 14:55
nickolaev
nickolaev approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way to have all our structures sorted. But I know - generics, right?

@jakubdyszkiewicz
fix integration test
9f93fc8 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit c222f52 into master Nov 30, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/eds-order branch November 30, 2020 14:00
mergify bot pushed a commit that referenced this pull request Nov 30, 2020
@jakubdyszkiewicz
fix(kuma-cp) generate stable EDS config (#1228)
ed26796 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit c222f52)
@mergify mergify bot mentioned this pull request Nov 30, 2020
Merged
nickolaev pushed a commit that referenced this pull request Dec 1, 2020
@mergify @jakubdyszkiewicz
fix(kuma-cp) generate stable EDS config (#1228) (#1234)
c3a3320 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit c222f52)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubdyszkiewicz @nickolaev @lobkovilya