chore(kuma-cp) change default flush intervals #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Dec 1, 2020
lobkovilya
approved these changes
Dec 1, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 47b8752)
nickolaev
pushed a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lower default flush intervals of Zone Insights and Dataplane Insights. We don't need to refresh the status that often, it's not critical for Kuma to function. Change it from 1s to 10s, to save an order of magnitude requests to the DB when there are many config changes.
Tradeoff - we will see DP online / offline and all stats changes with latency of 10s, not 1s.
I also parametrized Zone Insight since it was hardcoded.
Documentation