chore(*) get rid of hardcoded kuma-system namespace remains
#1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2020 12:17
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Dec 2, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
* chore(*) get rid of a redundant value in the chart Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> * chore(*) make install DNS defaults configurable Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> * fix(*) helm templates vfsdata Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 1904796) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
nickolaev
pushed a commit
that referenced
this pull request
Dec 2, 2020
…#1264) * chore(*) get rid of a redundant value in the chart Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> * chore(*) make install DNS defaults configurable Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> * fix(*) helm templates vfsdata Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 1904796) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get rid of the remaining hardcoded/unused values of
kuma-systemnamespace.Documentation