feat(kuma-cp) generate filterChainMatchers based on TrafficRoutes #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
nickolaev
approved these changes
Dec 11, 2020
jakubdyszkiewicz
approved these changes
Dec 11, 2020
| destination := destination. | ||
| WithoutTag(mesh_proto.ServiceTag). | ||
| WithTags("mesh", inbound.GetMesh()) | ||
| sni := tls.SNIFromServiceAndTags(service, destination) |
There was a problem hiding this comment.
IMHO instead of introducing
SNIFromServiceAndTags
I'd keep the tls. API simple and do
meshDestination := destination.WithTags("mesh", inbound.GetMesh())
sni := tls.SNIFromTags(meshDestination)
...
Tags: meshDestination.WithoutTag(mesh_proto.ServiceTag),
overall - as a rule of thumb I always double check the code when I'm introducing method with And if I can do it better.
There was a problem hiding this comment.
Actually, I did it at first, but then there is a problem - destination can have kuma.io/service: '*' and in this case, we should take service from the service variable
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # go.sum
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2020
) (cherry picked from commit ea214a4) # Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com
Summary
In order to support TrafficRoutes in Ingress level, we used to generate FilterChainMatch for all possibles combinations of tags. It's not efficient and might cause a really big Envoy config even if there are not so many tags.
The current implementation relies on the TrafficRoute policy. We collect all destinations from all TrafficRoutes and generate FilterChainMatch only for them. SelectorSubsets are also generated now based on TrafficRoutes. So we don't need
permutationpackage anymore.Documentation