Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-dp) HttpGet readiness (and liveness) probe path gets a "/" prepended if not supplied #1326

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(kuma-dp) HttpGet readiness (and liveness) probe path gets a "/" prepended if not supplied #1326

merged 1 commit into from
Dec 17, 2020

Conversation

lennartquerter
Copy link
Contributor

@lennartquerter lennartquerter commented Dec 16, 2020 •
edited

Signed-off-by: Lennart Querter lennart.querter@durstexpress.eu

Summary

If liveness probe (or readiness) httpGet path does not begins with "/", we add it automatically.

Issues resolved

Fix #1288

@lennartquerter lennartquerter requested a review from a team as a code owner December 16, 2020 17:29
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@subnetmarco
Copy link
Contributor

Thanks for the contribution, we will take a look into it shortly. + @lobkovilya

fix(kuma-dp) probe path gets a / prepended if not supplied
d27ea0a 
When not adding a /-prefix to the readiness or liveness probe, we should add it automatically.

Fix #1288

Signed-off-by: Lennart Querter <lennart.querter@durstexpress.eu>
nickolaev
nickolaev approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Congrats on the first contribution!

@nickolaev nickolaev merged commit 75ddff4 into kumahq:master Dec 17, 2020
mergify bot pushed a commit that referenced this pull request Dec 17, 2020
@lennartquerter
fix(kuma-dp) probe path gets a / prepended if not supplied (#1326)
b3983f7 
When not adding a /-prefix to the readiness or liveness probe, we should add it automatically.

Fix #1288

Signed-off-by: Lennart Querter <lennart.querter@durstexpress.eu>
(cherry picked from commit 75ddff4)
@mergify mergify bot mentioned this pull request Dec 17, 2020
Merged
nickolaev pushed a commit that referenced this pull request Dec 17, 2020
@mergify @lennartquerter
fix(kuma-dp) probe path gets a / prepended if not supplied (#1326) (#…
50205fe 
…1330)

When not adding a /-prefix to the readiness or liveness probe, we should add it automatically.

Fix #1288

Signed-off-by: Lennart Querter <lennart.querter@durstexpress.eu>
(cherry picked from commit 75ddff4)

Co-authored-by: Lennart Querter <lennart.querter@gmail.com>
@lennartquerter
Copy link
Contributor Author

Looks good to me.
Congrats on the first contribution!

Thank you! Always fun to contribute 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidecar injection fails if liveness probe (or readiness) httpGet path do not begins with "/"
4 participants
@lennartquerter @CLAassistant @subnetmarco @nickolaev