Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) bug with Ingress not belonging to the mesh #1344

Merged
merged 12 commits into from
Dec 22, 2020

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Dec 21, 2020

Summary

If workloads belong to mesh-1 but Ingresses belong to default mesh, then we won't generate outbounds for services in other zones.

In order to fix that several changes required:

Also updated e2e tests to support non-default Mesh deployments.

Documentation

Internal changes

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	go.sum
#	test/framework/interface.go
#	test/framework/setup.go
#	test/framework/universal_cluster.go
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner December 21, 2020 14:29
@lobkovilya lobkovilya changed the title fix(kuma-cp) bug with Ingress belonging to mesh fix(kuma-cp) bug with Ingress not belonging to the mesh Dec 21, 2020
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	api/go.sum
#	go.sum
#	pkg/plugins/resources/k8s/native/go.sum
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit 537751d into master Dec 22, 2020
@lobkovilya lobkovilya deleted the fix/ingress-in-another-mesh branch December 22, 2020 13:19
mergify bot pushed a commit that referenced this pull request Dec 22, 2020
nickolaev pushed a commit that referenced this pull request Dec 22, 2020
(cherry picked from commit 537751d)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants