-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mesh insights with DP versions #1372
Update mesh insights with DP versions #1372
Conversation
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
I tested this feature locally with 3 different versions of Kuma DP:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks solid! Could you write test for it in resyncer_test.go?
Yes, I could try to implement test for this feature. |
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
I added a test. |
Awesome, thanks! |
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com> (cherry picked from commit 6d8a862)
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Issues resolved
Fix #1327
Implementation
This feature is backward compatible and works with dataplanes that don't support versions and count them as
unknown
versions.