feat(kuma-cp) new status 'Partially degraded' for 'kumactl' #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctl' Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Jan 8, 2021
| return "Partially degraded" | ||
| } | ||
| return "Online" | ||
| } |
There was a problem hiding this comment.
nice, I like this piece of code. Very clear what is going on 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support new status for Dataplanes in
kumactl. So now there are 3 of themOnline/Offline/Partially degraded.This status is calculated based on the status of
kuma-dp(comes from DataplaneInsight) and based on the health of Dataplane inbounds.kuma-dpis offline, overall status is always: OFFLINE.kuma-dpis online and all the inbounds are running/ready, overall status is always: ONLINE.kuma-dpis online and one or more inbounds are offline (but not all the inbounds) overall status is: PARTIALLY DEGRADED. If all the inbounds are offline, overall status is: OFFLINE.The same functionality was added to GUI - kumahq/kuma-gui#109
Documentation