chore(kuma-cp) refactor to get rid of explicit V2 and parametrize api version #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Jan 8, 2021
lobkovilya
reviewed
Jan 8, 2021
| var _ sds_provider.Secret = &MeshCaSecret{} | ||
|
|
||
| func (s *MeshCaSecret) ToResource(name string) *envoy_auth.Secret { | ||
| func CreateCaSecret(secret *core_xds.CaSecret) *envoy_auth.Secret { |
There was a problem hiding this comment.
Why this is under xds directory? It's used once and from sds package
There was a problem hiding this comment.
Talked offline. sds will be moved to xds eventually. pkg/xds/envoy is a place when we try to abstract away envoy configs.
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Jan 8, 2021
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Jan 11, 2021
… version (#1379) Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of V2->V3 work. This PR introduces some refactoring to get rid of V2 dependencies across code to plug V3 components.
If any of this change may seem unnecessary, please look at the next PR with V3 code.