perf(kuma-cp) cached client for fetching secrets on k8s #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
bartsmykla
approved these changes
Jan 7, 2021
Comment on lines
+97
to
+103
| err = kubeCache.IndexField(context.Background(), &kube_core.Secret{}, "type", func(object kube_runtime.Object) []string { | ||
| secret := object.(*kube_core.Secret) | ||
| return []string{string(secret.Type)} | ||
| }) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "could not add index of Secret cache by field 'type'") | ||
| } |
There was a problem hiding this comment.
Why not:
Suggested change
| err = kubeCache.IndexField(context.Background(), &kube_core.Secret{}, "type", func(object kube_runtime.Object) []string { | |
| secret := object.(*kube_core.Secret) | |
| return []string{string(secret.Type)} | |
| }) | |
| if err != nil { | |
| return nil, errors.Wrap(err, "could not add index of Secret cache by field 'type'") | |
| } | |
| if err := kubeCache.IndexField(context.Background(), &kube_core.Secret{}, "type", func(object kube_runtime.Object) []string { | |
| secret := object.(*kube_core.Secret) | |
| return []string{string(secret.Type)} | |
| }); err != nil { | |
| return nil, errors.Wrap(err, "could not add index of Secret cache by field 'type'") | |
| } |
There was a problem hiding this comment.
It's less redable for me. I don't use if err := exp(); err != nil { when exp() is multiline.
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
reviewed
Jan 7, 2021
| @@ -232,9 +232,9 @@ func addValidators(mgr kube_ctrl.Manager, rt core_runtime.Runtime, converter k8s | |||
| mgr.GetWebhookServer().Register("/validate-v1-service", &kube_webhook.Admission{Handler: &k8s_webhooks.ServiceValidator{}}) | |||
| log.Info("Registering a validation webhook for v1/Service", "path", "/validate-v1-service") | |||
|
|
|||
| client, ok := k8s_extensions.FromNonCachedClientContext(rt.Extensions()) | |||
| client, ok := k8s_extensions.FromSecretClientContext(rt.Extensions()) | |||
There was a problem hiding this comment.
Is it possible to receive a request in the SecretValidator webhook which is not for kuma-system namespace?
There was a problem hiding this comment.
no
- name: secret.validator.kuma-admission.kuma.io
namespaceSelector:
matchLabels:
kuma.io/system-namespace: "true"
lobkovilya
approved these changes
Jan 7, 2021
nickolaev
approved these changes
Jan 7, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 04cd0de)
nickolaev
pushed a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See the explanation in the comment of the code. We used non-cached client for Secrets on Kubernetes because we could not use the regular cached client in ControllerManager. This was ok until we introduced Secrets into reconciliation loop (Secrets are taken into account of Mesh Hash, because Secrets are used for TLS settings of External Service).
This change brings a separate cached client for Secrets.
Documentation