feat(kuma-cp) proxy template V3 #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feat/v3-components
branch
2 times, most recently
from
bf78c59
to
1b3ac67
Compare
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
force-pushed
the
chore/proxy-template-v3
branch
from
a164fa7
to
d1795d7
Compare
nickolaev
approved these changes
Jan 11, 2021
| list = append(list, s.ListOf(envoy_resource_v2.ListenerType)...) | ||
| list = append(list, s.ListOf(envoy_resource_v3.ListenerType)...) | ||
| list = append(list, s.ListOf(envoy_resource_v2.SecretType)...) | ||
| list = append(list, s.ListOf(envoy_resource_v3.SecretType)...) |
There was a problem hiding this comment.
nit: Hmm shall we split thes to v2/v3 specifics instead of mixing these side by side?
lobkovilya
approved these changes
Jan 11, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 5eaee19) # Conflicts: # pkg/xds/envoy/clusters/v3/health_check_configurer_test.go
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jan 12, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Jan 12, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR supports Proxy Template for API V3. There was no good abstraction for it, so the current code was moved to sub package V2 and V3 is essentialy copy of V2 code with fixed imports and typeurls.
Also added explicit V3 version to EDS clusters.