chore(*) versions bump and CI go cache #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/versions_bump
branch
2 times, most recently
from
e5f133e
to
75955ea
Compare
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/versions_bump
branch
from
75955ea
to
6ba26b2
Compare
nickolaev
changed the title
jakubdyszkiewicz
approved these changes
Jan 12, 2021
| @@ -36,3 +36,6 @@ issues: | |||
| - linters: | |||
| - staticcheck | |||
| text: "SA1019: l.UseOriginalDst is deprecated: Do not use." # TODO What is the up-to-date alternative ? | |||
| - linters: | |||
| - staticcheck | |||
| text: "c.Http2ProtocolOptions is deprecated: Do not use." # TODO What is the up-to-date alternative ? | |||
There was a problem hiding this comment.
I was pretty sure that comment in the code that ignores it was enough. Did something change with a new version?
There was a problem hiding this comment.
Yep the messages did appear on my computer so I had to disable it.
| @@ -220,6 +212,7 @@ jobs: | |||
|
|
|||
| check: | |||
| executor: golang | |||
| resource_class: large | |||
There was a problem hiding this comment.
The real reason for this PR as far as I understand is this line because golanglint-ci has not enough memory.
We need to add this reason either in PR or here as a little comment (I prefer the latter)
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2021
* chore(*) versions bump * test(*) ci cache optimization Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit d89548d)
nickolaev
pushed a commit
that referenced
this pull request
Jan 13, 2021
austince
pushed a commit
to hvydya/kuma
that referenced
this pull request
Jan 17, 2021
* chore(*) versions bump * test(*) ci cache optimization Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the falling CI check and bumping versions meanwhile:
make vet