feat(kuma-dp) override bootstrap version #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…de-bootstrap-ver Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Jan 13, 2021
| @@ -64,6 +64,7 @@ func (b *BootstrapHandler) Handle(resp http.ResponseWriter, req *http.Request) { | |||
|
|
|||
| resp.WriteHeader(http.StatusOK) | |||
| resp.Header().Set("content-type", "text/x-yaml") | |||
| resp.Header().Set(types.BootstrapVersionHeader, string(version)) | |||
There was a problem hiding this comment.
Maybe a better approach would be to convert this to a GRPC service and gave a dedicated field instead of the header. But I guess we can live with it as it is proposed.
There was a problem hiding this comment.
gRPC is overkill in my opionion. Simple REST service with JSON with fields "version" and "bootstrap config" is probably a better idea of those two, but this brings even more problems with backward compatibility, so unless we need more control I'd stick to this for now.
bartsmykla
approved these changes
Jan 14, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 118e86f) # Conflicts: # pkg/sds/server/v3/server_test.go # pkg/xds/bootstrap/generator.go
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jan 14, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Jan 15, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
austince
pushed a commit
to hvydya/kuma
that referenced
this pull request
Jan 17, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an option to override Bootstrap Version on Kuma DP side.
The regular case is that Kuma CP decides which Bootstrap Version (and API Version) it will serve to the DP.
Envoy 1.17 technically drops V2 support, but you can still use it when you specify explicitly
--bootstrap-verison 2as CLI args to Envoy.Kuma DP did not know about Bootstrap version so far, so I added extra header that we return from the Kuma CP so Kuma DP can pass the version to Envoy.
Additionally, there are some cases when you would like to override Bootstrap Version for one Kuma DP (for example to V3, while keeping the default Bootstrap to V2 for all other DPs). Those use cases are
Documentation