Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the panic in IsIngress() function when networking is nil #1424

Merged
merged 5 commits into from
Jan 15, 2021
Merged

fixed the panic in IsIngress() function when networking is nil #1424

merged 5 commits into from
Jan 15, 2021

Conversation

nikita15p
Copy link
Contributor

Summary

SUMMARY_GOES_HERE

Full changelog

  • Added following check before dataplane.networking.Ingress is returned
    if d.GetNetworking() == nil {
    return false
    }
  • Fixes the panic when following is the request body of PUT /meshes/{mesh}/dataplanes/{name}:
    Request Body: (for eg)
    {
    "type": "Dataplane",
    "name": "backend-1",
    "mesh": "mesh-1"
    }

Issues resolved

Fix panic when networking field is empty during dataplane HTTP PUT API request

Documentation

NA

@nikita15p nikita15p requested a review from a team as a code owner January 15, 2021 09:24
@jakubdyszkiewicz jakubdyszkiewicz merged commit 5dc8c3c into kumahq:master Jan 15, 2021
@jakubdyszkiewicz
Copy link
Contributor

thanks!

mergify bot pushed a commit that referenced this pull request Jan 15, 2021
@nikita15p
fix(kuma-cp) nil check in IsIngress() to avoid panic when validating (#…
0679e73 
…1424)

Signed-off-by: nikita15p <nikita15p@gmail.com>
(cherry picked from commit 5dc8c3c)
@mergify mergify bot mentioned this pull request Jan 15, 2021
Merged
jakubdyszkiewicz pushed a commit that referenced this pull request Jan 15, 2021
@mergify
fix(kuma-cp) nil check in IsIngress() to avoid panic when validating (#…
8cb56d1 
…1424)

Signed-off-by: nikita15p <nikita15p@gmail.com>
austince pushed a commit to hvydya/kuma that referenced this pull request Jan 17, 2021
@nikita15p @austince
fix(kuma-cp) nil check in IsIngress() to avoid panic when validating (k…
47e3096 
…umahq#1424)

Signed-off-by: nikita15p <nikita15p@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikita15p @jakubdyszkiewicz