Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-dp) Expose the possibility to add ProxyTemplates publicly #1452

Merged
merged 1 commit into from
Jan 20, 2021
Merged

feat(kuma-dp) Expose the possibility to add ProxyTemplates publicly #1452

merged 1 commit into from
Jan 20, 2021

Conversation

lahabana
Copy link
Contributor

Populating the predefinedProfiles map was not possible publicly.
This is limiting for anyone wanting to make custom profiles

feat(kuma-dp) Expose the possibility to add ProxyTemplates publicly
c5745c9 
Populating the predefinedProfiles map was not possible publicly.
This is limiting for anyone wanting to make custom profiles

Signed-off-by: Charly Molter <charly@koyeb.com>
@lahabana lahabana requested a review from a team as a code owner January 20, 2021 14:15
@lahabana
Copy link
Contributor Author

Seems like build failed for an unrelated issue. Can someone retrigger the build?

@nickolaev nickolaev merged commit 004a4e1 into kumahq:master Jan 20, 2021
mergify bot pushed a commit that referenced this pull request Jan 20, 2021
feat(kuma-dp) Expose the possibility to add ProxyTemplates publicly (#…
1509302 
…1452)

Populating the predefinedProfiles map was not possible publicly.
This is limiting for anyone wanting to make custom profiles

Signed-off-by: Charly Molter <charly@koyeb.com>
(cherry picked from commit 004a4e1)
@mergify mergify bot mentioned this pull request Jan 20, 2021
Merged
nickolaev pushed a commit that referenced this pull request Jan 20, 2021
@mergify
feat(kuma-dp) Expose the possibility to add ProxyTemplates publicly (#…
0bec5e1 
…1452) (#1456)

Populating the predefinedProfiles map was not possible publicly.
This is limiting for anyone wanting to make custom profiles

Signed-off-by: Charly Molter <charly@koyeb.com>
(cherry picked from commit 004a4e1)

Co-authored-by: Charly Molter <charly@koyeb.com>
@lahabana lahabana deleted the feat/pluggable-proxy-profiles branch March 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lahabana @jakubdyszkiewicz @nickolaev