fix(*) network attachment definitions for CNI #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 17, 2021 03:10
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Feb 18, 2021
added 2 commits
February 18, 2021 15:15
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2021
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 29bbdc5) # Conflicts: # api/mesh/v1alpha1/health_check.pb.go # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
nickolaev
pushed a commit
that referenced
this pull request
Feb 19, 2021
* fix(kuma-cp) network attachment definitions for CNI (#1569) Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 29bbdc5) # Conflicts: # api/mesh/v1alpha1/health_check.pb.go # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go * fix(*) conflicts Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only create/delete NetworkAttachmentDefinitions when needed (i.e. OpenShift with MultusCNI).
Installing multus is as simple as applying this:
https://raw.githubusercontent.com/intel/multus-cni/master/images/multus-daemonset.yml
Fixes #1547
Documentation