Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: zipkin config add shared span context option #1660

Merged
merged 2 commits into from
Mar 11, 2021
Merged

feat: zipkin config add shared span context option #1660

merged 2 commits into from
Mar 11, 2021

Conversation

ericmustin
Copy link
Contributor

@ericmustin ericmustin commented Mar 10, 2021 •
edited by austince

Signed-off-by: ericmustin mustin.eric@gmail.com

Summary

(Sorry, had pushed up some unwanted changes to go.mod on other branch.)

This PR addresses #1656 by adding support for zipkins shared_span_context

Full changelog

  • [Implement shared_span_context configuration for envoy zipkin tracer]

Issues resolved

Closes #1656

Documentation

@ericmustin
feat: zipkin config add shared span context option
209ecc7 
Signed-off-by: ericmustin <mustin.eric@gmail.com>
@ericmustin ericmustin requested a review from a team as a code owner March 10, 2021 20:16
@ericmustin
feat: zipkin config linting
8f7b2f0 
Signed-off-by: ericmustin <mustin.eric@gmail.com>
@ericmustin
Copy link
Contributor Author

ericmustin commented Mar 10, 2021 •
edited

Not sure why the minikube_v1_18-1 workflow step is failing here (i can't kick it as i don't have those circleci rights), looks unrelated to this pr, but otherwise I think this is good to review.

@austince
Copy link
Contributor

Not sure why the minikube_v1_18-1 workflow step is failing here (i can't kick it as i don't have those circleci rights), looks unrelated to this pr, but otherwise I think this is good to review.

I re-ran it – looks good @ericmustin !

@nickolaev
Copy link
Contributor

Hmm maybe we need docs update for this?

@nickolaev nickolaev merged commit 3ddeb41 into kumahq:master Mar 11, 2021
@mergify mergify bot mentioned this pull request Mar 11, 2021
Merged
mergify bot pushed a commit that referenced this pull request Mar 11, 2021
@ericmustin
feat: zipkin config add shared span context option (#1660)
540a38e 
* feat: zipkin config add shared span context option

Signed-off-by: ericmustin <mustin.eric@gmail.com>
(cherry picked from commit 3ddeb41)
nickolaev pushed a commit that referenced this pull request Mar 11, 2021
@mergify @ericmustin
feat: zipkin config add shared span context option (#1660) (#1669)
f0144c8 
* feat: zipkin config add shared span context option

Signed-off-by: ericmustin <mustin.eric@gmail.com>
(cherry picked from commit 3ddeb41)

Co-authored-by: Eric Mustin <mustin.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Zipkin shared_span_context Configuration
4 participants
@ericmustin @austince @nickolaev @jakubdyszkiewicz