Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp) race condition with ExternalService #1694

Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix(kuma-cp) race condition with ExternalService #1694

merged 1 commit into from
Mar 17, 2021

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Mar 16, 2021 •
edited

Summary

Kuma CP was panicking with concurrent map read and map write because of race condition. It was clearly seen on Universal with TransparentProxy enabled with ~100 data plane proxies and at least 1 external service.

Full changelog

  • replace an in-place write to map with 'WithTags' method

Documentation

  • no need

@lobkovilya
fix(kuma-cp) replace an in-place write to map with 'WithTags' method
1881dec 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner March 16, 2021 17:33
@lobkovilya lobkovilya changed the title fix(kuma-cp) replace an in-place write to map with 'WithTags' method fix(kuma-cp) race condition with ExternalService Mar 16, 2021
@lobkovilya lobkovilya merged commit eb224fe into master Mar 17, 2021
@lobkovilya lobkovilya deleted the fix/es-race-condition branch March 17, 2021 11:18
mergify bot pushed a commit that referenced this pull request Mar 17, 2021
@lobkovilya
fix(kuma-cp) replace an in-place write to map with 'WithTags' method (#…
4eac9ac 
…1694)

(cherry picked from commit eb224fe)
@mergify mergify bot mentioned this pull request Mar 17, 2021
Merged
nickolaev pushed a commit that referenced this pull request Mar 18, 2021
@mergify @lobkovilya
fix(kuma-cp) replace an in-place write to map with 'WithTags' method (#…
c29d33d 
…1694) (#1697)

(cherry picked from commit eb224fe)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lobkovilya @nickolaev @jakubdyszkiewicz