Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-dp) validate --name and --mesh when dataplane is provided #1771

Merged
merged 2 commits into from
Apr 8, 2021
Merged

chore(kuma-dp) validate --name and --mesh when dataplane is provided #1771

merged 2 commits into from
Apr 8, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

having an option to provide --name and --mesh with --dataplane-file is confusing because mesh and name in dataplane definition takes precedence. Added validation that you cannot use --name or --mesh with --dataplane-file.

This is a slightly breaking change because I had to change that --mesh not by default is not default but needs to be explicitly provided.

Documentation

  • No docs

@jakubdyszkiewicz
chore(kuma-dp) validate --name and --mesh when dataplane is provided
e2d3de5 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner April 6, 2021 13:01
@nickolaev
Copy link
Contributor

  • shall we update docs that now the mesh is required?
  • if "slightly" breaking, do we want it in the release? My opinion is yes.

@jakubdyszkiewicz
Copy link
Contributor Author

jakubdyszkiewicz commented Apr 6, 2021 •
edited

Checked all the occurences in the docs. We use --dataplane-file aside of mesh.md when we provide --mesh arg.

Yeah, I'm leaning towards merging this to the release branch. I think majority of use cases are --dataplane-file now anyways.

bartsmykla
bartsmykla approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubdyszkiewicz
fix test
311a975 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@nickolaev nickolaev merged commit 9a2da4b into master Apr 8, 2021
@nickolaev nickolaev deleted the chore/name-mesh-kuma-dp-validation branch April 8, 2021 10:40
mergify bot pushed a commit that referenced this pull request Apr 8, 2021
@jakubdyszkiewicz
chore(kuma-dp) validate --name and --mesh when dataplane is provided (#…
4d4b6eb 
…1771)

* chore(kuma-dp) validate --name and --mesh when dataplane is provided

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 9a2da4b)
@mergify mergify bot mentioned this pull request Apr 8, 2021
Merged
nickolaev pushed a commit that referenced this pull request Apr 8, 2021
@mergify @jakubdyszkiewicz
chore(kuma-dp) validate --name and --mesh when dataplane is provided (#…
b144e22 
…1771) (#1780)

* chore(kuma-dp) validate --name and --mesh when dataplane is provided

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 9a2da4b)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubdyszkiewicz @nickolaev @bartsmykla