-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*) iptables for DNS redirection #1808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Apr 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2021
* chore(*) import changes from release-1.10 * chore(kumactl) transparent proxy constants * chore(transparentproxy) forward port ipv6 inbound port * chore(transparentproxy) redirect DNS to a set port * chore(transparentproxy) handle IPv6 DNS servers redirect * chore(transparentproxy) high level redirect DNS configure Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit bb6ebb0) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
nickolaev
pushed a commit
that referenced
this pull request
Apr 15, 2021
* chore(*) import changes from release-1.10 * chore(kumactl) transparent proxy constants * chore(transparentproxy) forward port ipv6 inbound port * chore(transparentproxy) redirect DNS to a set port * chore(transparentproxy) handle IPv6 DNS servers redirect * chore(transparentproxy) high level redirect DNS configure Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit bb6ebb0) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
pushed a commit
that referenced
this pull request
Apr 15, 2021
* chore(*) import changes from release-1.10 * chore(kumactl) transparent proxy constants * chore(transparentproxy) forward port ipv6 inbound port * chore(transparentproxy) redirect DNS to a set port * chore(transparentproxy) handle IPv6 DNS servers redirect * chore(transparentproxy) high level redirect DNS configure Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit bb6ebb0) # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To enable iptables port redirect to the local IP:
kumactl install transparent-proxy --kuma-dp-uid 1000 --kuma-cp-ip 1.2.3.4 --redirect-dns --redirect-dns-port 15053
KUMA_RUNTIME_KUBERNETES_INJECTOR_SIDECAR_CONTAINER_USE_BUILTIN_DNS=true
Note:
This PR changes the behavior of
kumactl install transparent-proxy
by replacing--skip-resolv-conf
with--modify-resolv-conf
which is reflected in the e2e test framework'ssetupTransparent
. Eventually, this should be replaced with--redirect-dns
.TODO:
Make the relevant changes in the CNI so we can handle the DNS redirection
Documentation