Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) add 'ginkgo unfocus' #1813

Merged
merged 1 commit into from
Apr 14, 2021
Merged

chore(kuma-cp) add 'ginkgo unfocus' #1813

merged 1 commit into from
Apr 14, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

If you ever forgot to get rid of FIt or FEntry before the commit, then it's not the case anymore!

Full changelog

  • add make ginkgo/unfocus as a part of make check

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner April 14, 2021 12:39
@lobkovilya lobkovilya changed the title feat(kuma-cp) add 'ginkgo unfocus' chore(kuma-cp) add 'ginkgo unfocus' Apr 14, 2021
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :-)

@jakubdyszkiewicz
Copy link
Contributor

sweet! 👏

@nickolaev nickolaev merged commit 7cbb5ff into master Apr 14, 2021
@nickolaev nickolaev deleted the chore/ginkgo-unfocus branch April 14, 2021 13:43
mergify bot pushed a commit that referenced this pull request Apr 14, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
(cherry picked from commit 7cbb5ff)
jakubdyszkiewicz pushed a commit that referenced this pull request Apr 14, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants