fix(kuma-cp) fixes and E2E tests of Builtin DNS #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
* dns fixes * e2e kube test * e2e test on universal Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 98050e6) # Conflicts: # app/kumactl/cmd/install/install_transparent_proxy.go # mk/build.mk # test/e2e/externalservices/externalservices_universal_test.go # test/framework/universal_app.go # test/framework/universal_cluster.go
jakubdyszkiewicz
added a commit
that referenced
this pull request
Apr 16, 2021
* dns fixes * e2e kube test * e2e test on universal Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Apr 16, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various fixes to integrate builtin DNS
Answer TTL has to be 30s or above
CoreDNS has
-quietflagFixed Makefiles for building CoreDNS
DNS Generator has to generate listener on 127.0.0.1 only
Added E2E test on Kubernetes for the most common scenario (someone is using external service, when passthrough is false, it is blocked, when we add ExternalService with proper url and port, it is consumable again)
Added E2E test on Universal