Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) update postgres certs for integration tests #1851

Merged
merged 2 commits into from
Apr 20, 2021
Merged

chore(*) update postgres certs for integration tests #1851

merged 2 commits into from
Apr 20, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

Regenerate postgres.server.crt and postgres.client.crt, add script to do so based on existing rootCA.crt

@lobkovilya
chore(*) update postgres certs
425c551 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner April 19, 2021 15:30
jakubdyszkiewicz
jakubdyszkiewicz reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 5000 days, not 500? 1.5y seems like a lot, but it can bite us exactly the same way it did this time when we were releasing.

@jakubdyszkiewicz
Copy link
Contributor

also please restore integration to circleCI

bartsmykla
bartsmykla approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakubdyszkiewicz
chore(kuma-cp) regenerate certs with CA that lasts for 10000 days
d2c8774 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@lobkovilya lobkovilya merged commit a57dc09 into master Apr 20, 2021
@lobkovilya lobkovilya deleted the chore/update-postgres-certs branch April 20, 2021 14:36
mergify bot pushed a commit that referenced this pull request Apr 20, 2021
@lobkovilya
chore(*) update postgres certs for integration tests (#1851)
b2d9adf 
(cherry picked from commit a57dc09)
@mergify mergify bot mentioned this pull request Apr 20, 2021
Merged
nickolaev pushed a commit that referenced this pull request Apr 21, 2021
@mergify @lobkovilya
chore(*) update postgres certs for integration tests (#1851) (#1855)
6178bb4 
(cherry picked from commit a57dc09)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz left review comments

@nickolaev nickolaev nickolaev approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lobkovilya @jakubdyszkiewicz @nickolaev @bartsmykla