Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) upgrade Go to 16.3 #1864

Merged
merged 3 commits into from
Apr 22, 2021
Merged

chore(*) upgrade Go to 16.3 #1864

merged 3 commits into from
Apr 22, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Upgrade Go to 16.3 so we can use the embed feature.

@jakubdyszkiewicz
chore(*) upgrade Go to 16.3
aeedde2 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner April 21, 2021 14:12
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the chore/go-16 branch 4 times, most recently from 0001c9f to ae63512 Compare April 22, 2021 08:57
@jakubdyszkiewicz
go install instead of go get
d3386df 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
nickolaev approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! We are getting a modern compiler. Let's get it going.

@nickolaev
Copy link
Contributor

Shall we bump that protoc version now:

--- a/pkg/config/app/kumactl/v1alpha1/config.pb.go
+++ b/pkg/config/app/kumactl/v1alpha1/config.pb.go
@@ -1,6 +1,6 @@
 // Code generated by protoc-gen-go. DO NOT EDIT.
 // versions:
-// 	protoc-gen-go v1.25.0
+// 	protoc-gen-go v1.23.0
 // 	protoc        v3.14.0
 // source: pkg/config/app/kumactl/v1alpha1/config.proto

@jakubdyszkiewicz jakubdyszkiewicz force-pushed the chore/go-16 branch 2 times, most recently from cfab712 to 891bd13 Compare April 22, 2021 09:39
@jakubdyszkiewicz
update protos
ee44906 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
Copy link
Contributor Author

Shall we bump that protoc version now:

I'd rather avoid this.
As far as I understand this now requires to bump protoc-gen-go. Next version is major, so I expect more problems. I don't want to do this in this PR.

@nickolaev

@jakubdyszkiewicz jakubdyszkiewicz merged commit 8caa020 into master Apr 22, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/go-16 branch April 22, 2021 10:36
mergify bot pushed a commit that referenced this pull request Apr 22, 2021
@jakubdyszkiewicz
chore(*) upgrade Go to 16.3 (#1864)
34dafc0 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 8caa020)

# Conflicts:
#	api/go.mod
#	api/go.sum
#	api/observability/v1/mads.pb.go
@mergify mergify bot mentioned this pull request Apr 22, 2021
Merged
jakubdyszkiewicz added a commit that referenced this pull request Apr 22, 2021
@jakubdyszkiewicz
chore(*) upgrade Go to 16.3 (#1864)
44534f6 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz pushed a commit that referenced this pull request Apr 22, 2021
@mergify
chore(*) upgrade Go to 16.3 (#1864)
6785caa 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @nickolaev