Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests) kumactl tests fix #1891

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

bartsmykla
Copy link
Contributor

Summary

Test fix for kumactl as with https://github.com/kumahq/kuma/pull/1879/files#diff-51a6a652c3bb67a29021ea8a2773a31955ea8bbe9116113f34afcd91f50aca34R65

NewAPIServerClient func(*config_proto.ControlPlaneCoordinates_ApiServer) (kumactl_resources.ApiServerClient, error)
have to be defined in RootContext

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner April 27, 2021 14:43
Signed-off-by: Bart Smykla <bartek@smykla.com>
Copy link
Contributor

@parkanzky parkanzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bartsmykla bartsmykla merged commit 448c14e into kumahq:master Apr 27, 2021
@bartsmykla bartsmykla deleted the fix/kumactl-tests branch April 27, 2021 15:40
mergify bot pushed a commit that referenced this pull request Apr 27, 2021
* fix(tests) kumactl tests fix

Signed-off-by: Bart Smykla <bartek@smykla.com>

* fix(tests) get_single_resource mock fix

Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit 448c14e)
bartsmykla pushed a commit that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants