feat(kumactl) Add option to install Kong ingress #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
parkanzky
force-pushed
the
feat/kumactl-install-gateway
branch
from
fc20c08
to
70b643b
Compare
jakubdyszkiewicz
requested changes
May 4, 2021
* More specific testing of errors * Add side-car injection enabled * Removed extraneous KUBECONFIG help text * Add ingress types to help text * Remove extraneous namespace file Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
jakubdyszkiewicz
approved these changes
May 4, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 4, 2021
* feat(kumactl) Add option to install Kong ingress Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kumactl) Address PR comments * More specific testing of errors * Add side-car injection enabled * Removed extraneous KUBECONFIG help text * Add ingress types to help text * Remove extraneous namespace file Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit d43e0ec)
nickolaev
pushed a commit
that referenced
this pull request
May 10, 2021
) * feat(kumactl) add option to install Kong ingress (#1929) * feat(kumactl) Add option to install Kong ingress Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kumactl) Address PR comments * More specific testing of errors * Add side-car injection enabled * Removed extraneous KUBECONFIG help text * Add ingress types to help text * Remove extraneous namespace file Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit d43e0ec) * fix(*) make check Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> Co-authored-by: parkanzky <42279121+parkanzky@users.noreply.github.com> Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add option to install an ingress gateway to kubernetes. Currently only supports Kong ingress, but takes type on command line.
kumactl install gateway --type kong | kubectl apply -f -Full changelog