feat(kumactl) Add option to install kuma demo app #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
jakubdyszkiewicz
requested changes
May 4, 2021
added 2 commits
May 4, 2021 12:44
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
* Fix help text * Drop service-upstream annotation * rm TODO comment Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
jakubdyszkiewicz
approved these changes
May 10, 2021
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2021
* feat(kumactl) Add option to install kuma demo app Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kumactl) Update with make check Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kumactl) Address PR comments * Fix help text * Drop service-upstream annotation * rm TODO comment Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kumactl) Update with make check Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit de4e54d)
nickolaev
pushed a commit
that referenced
this pull request
May 11, 2021
* feat(kumactl) Add option to install kuma demo app Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kumactl) Update with make check Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kumactl) Address PR comments * Fix help text * Drop service-upstream annotation * rm TODO comment Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kumactl) Update with make check Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit de4e54d) Co-authored-by: parkanzky <42279121+parkanzky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Parkanzky paul.parkanzky@konghq.com
Summary
Add option to install kuma demo application onto kubernetes, with optional
zoneargument.kumactl install demo | kubectl apply -f -Full changelog