feat(kuma-cp) allow tcp/http healthchecks together #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows describing both, TCP and HTTP health checks together in one resource manifest Signed-off-by: Bart Smykla <bartek@smykla.com>
1 task
jakubdyszkiewicz
approved these changes
May 6, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2021
This change allows describing both, TCP and HTTP health checks together in one resource manifest Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit ace33cc) # Conflicts: # api/mesh/v1alpha1/health_check.pb.go
nickolaev
pushed a commit
that referenced
this pull request
May 10, 2021
…1954) * feat(kuma-cp) allow tcp/http healthchecks together (#1951) This change allows describing both, TCP and HTTP health checks together in one resource manifest Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit ace33cc) # Conflicts: # api/mesh/v1alpha1/health_check.pb.go * chore(*) make generate results Signed-off-by: Bart Smykla <bartek@smykla.com> * fix(*) make check Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> Co-authored-by: Bart Smykla <bartek@smykla.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change allows describing both, TCP and HTTP health checks
together in one resource manifest
It should be a safe change as it's not introducing or/and removing any field in our manifests. It can be treated as a breaking change if somebody is using our proto files (but I think we can assume the risk is very low).
This change is a result of #1927 (comment)
It doesn't fully resolve the issue, as we are adding option to put TCP and HTTP health checks (one per each) in one manifest.
It shouldn't be a hard change to let us put multiple of "health checks" for any type in one manifest but it would be definitely a breaking change
Documentation