fix(kuma-dp) validate the DP proxy type

[jpeach]

Summary

Validate that the kuma-dp proxy type nust be "ingress" or "dataplane".

Full changelog

• Fix kuma-dp --proxy-type flag validation

Issues resolved

N/A

Documentation

N/A

Testing

• Unit tests
• E2E tests
• Manual testing on Universal
• Manual testing on Kubernetes

[lobkovilya]

Thanks for fixing this! Look good, but probably it makes sense to move this check to Config#Validate method: https://github.com/kumahq/kuma/blob/master/pkg/config/app/kuma-dp/config.go#L191. There is already a call proxyType.IsValid() but I didn't take into account that proxyType contains gateway as well, which today we don't want to see as an option.

[jpeach]

Thanks for fixing this! Look good, but probably it makes sense to move this check to Config#Validate method: https://github.com/kumahq/kuma/blob/master/pkg/config/app/kuma-dp/config.go#L191. There is already a call proxyType.IsValid() but I didn't take into account that proxyType contains gateway as well, which today we don't want to see as an option.

Ah I see. I agree it makes sense to validate there as well. I'd like to also keep the validation in run.go since that ensure we load the right resource type.

[jpeach]

@lobkovilya I updated the validation PTAL

[codecov-commenter]

Codecov Report

Merging #2186 (0483abb) into master (46e5b11) will increase coverage by 0.31%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
+ Coverage   51.75%   52.06%   +0.31%     
==========================================
  Files         909      913       +4     
  Lines       40998    41040      +42     
==========================================
+ Hits        21218    21367     +149     
+ Misses      17744    17614     -130     
- Partials     2036     2059      +23     

Impacted Files	Coverage Δ
app/kuma-dp/cmd/run.go	71.32% <55.55%> (+2.31%)	⬆️
pkg/config/app/kuma-dp/config.go	67.34% <100.00%> (+1.75%)	⬆️
pkg/core/resources/manager/manager.go	80.64% <0.00%> (-3.23%)	⬇️
pkg/core/resources/model/rest/resource.go	57.40% <0.00%> (-1.86%)	⬇️
...k8s/native/controllers/proxytemplate_controller.go	0.00% <0.00%> (ø)
api/internal/util/proto/proto.go	62.50% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go	100.00% <0.00%> (ø)
api/internal/util/proto/types.go	50.00% <0.00%> (ø)
api/observability/v1/mads.pb.go	35.94% <0.00%> (+1.30%)	⬆️
pkg/xds/generator/direct_access_proxy_generator.go	81.57% <0.00%> (+1.31%)	⬆️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e5b11...0483abb. Read the comment docs.