Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) drop gogo/protobuf dependency #2199

Merged
merged 1 commit into from
Jun 24, 2021
Merged

chore(*) drop gogo/protobuf dependency #2199

merged 1 commit into from
Jun 24, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 24, 2021

Summary

Drop the accidental dependency on gogo/protobuf, since we are using
golang/protobuf everywhere.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Drop the accidental dependency on gogo/protobuf, since we are using
golang/protobuf everywhere.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner June 24, 2021 02:20
@jpeach
Copy link
Contributor Author

jpeach commented Jun 24, 2021

@lobkovilya Could you review please?

@jakubdyszkiewicz jakubdyszkiewicz merged commit 2a9eb33 into kumahq:master Jun 24, 2021
mergify bot pushed a commit that referenced this pull request Jun 24, 2021
Drop the accidental dependency on gogo/protobuf, since we are using
golang/protobuf everywhere.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 2a9eb33)
jakubdyszkiewicz pushed a commit that referenced this pull request Jun 24, 2021
Drop the accidental dependency on gogo/protobuf, since we are using
golang/protobuf everywhere.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach deleted the chore/drop-gogo-dependency branch June 24, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants