-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp) ZoneIngress shows up as 'offline' #2209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Please provide E2E test for this.
and I'd also do then
|
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # api/mesh/v1alpha1/zoneingress_overview.pb.go
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2209 +/- ##
===========================================
- Coverage 51.68% 15.50% -36.19%
===========================================
Files 899 47 -852
Lines 40752 6400 -34352
===========================================
- Hits 21061 992 -20069
+ Misses 17672 5327 -12345
+ Partials 2019 81 -1938
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Jun 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
(cherry picked from commit 52acd1f) # Conflicts: # api/mesh/v1alpha1/zoneingress_overview.pb.go
lobkovilya
added a commit
that referenced
this pull request
Jun 28, 2021
lobkovilya
added a commit
that referenced
this pull request
Jun 28, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # api/mesh/v1alpha1/zoneingress_overview.pb.go
lobkovilya
pushed a commit
that referenced
this pull request
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The initial plan was to use
DataplaneInsight
internally asZoneIngressInsight
. That was working well on Kubernetes, but for UniversalZoneIngressInsight
wasn't synced over KDS.Current PR introduces a separate proto
ZoneIngressInsight
to have a unified approach both on Kubernetes and Universal.Full changelog
Issues resolved
Fix #2197
Documentation
Testing