Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) ZoneIngress shows up as 'offline' #2209

Merged
merged 6 commits into from
Jun 28, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

The initial plan was to use DataplaneInsight internally as ZoneIngressInsight. That was working well on Kubernetes, but for Universal ZoneIngressInsight wasn't synced over KDS.

Current PR introduces a separate proto ZoneIngressInsight to have a unified approach both on Kubernetes and Universal.

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #2197

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner June 24, 2021 12:06
@jakubdyszkiewicz
Copy link
Contributor

Please provide E2E test for this.

  • spawn global
  • spawn remote kubernetes with zone and service
  • spawn remote universal with zone and service
  • check if zoneingress and dataplanes are synced and online

and I'd also do then

  • scale down / remove dataplanes
  • check that there are no zoneingresses and dataplanes in global

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	api/mesh/v1alpha1/zoneingress_overview.pb.go
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2209 (08346dd) into master (3bd7955) will decrease coverage by 36.18%.
The diff coverage is 28.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2209       +/-   ##
===========================================
- Coverage   51.68%   15.50%   -36.19%     
===========================================
  Files         899       47      -852     
  Lines       40752     6400    -34352     
===========================================
- Hits        21061      992    -20069     
+ Misses      17672     5327    -12345     
+ Partials     2019       81     -1938     
Impacted Files Coverage Δ
api/mesh/v1alpha1/zone_ingress_insight_helpers.go 0.00% <0.00%> (ø)
api/mesh/v1alpha1/zone_ingress_insight.pb.go 41.50% <41.50%> (ø)
api/mesh/v1alpha1/zoneingress_overview.pb.go 36.84% <100.00%> (ø)
api/mesh/v1alpha1/mesh_helpers.go 0.00% <0.00%> (-75.00%) ⬇️
api/mesh/v1alpha1/timeout_helpers.go 0.00% <0.00%> (-66.67%) ⬇️
api/system/v1alpha1/zone_insight_helpers.go 0.00% <0.00%> (-48.65%) ⬇️
api/mesh/v1alpha1/externalservice_helpers.go 0.00% <0.00%> (-39.29%) ⬇️
api/mesh/v1alpha1/circuit_breaker.pb.go 7.43% <0.00%> (-38.67%) ⬇️
api/mesh/v1alpha1/fault_injection.pb.go 12.08% <0.00%> (-35.17%) ⬇️
api/mesh/v1alpha1/rate_limit.pb.go 12.08% <0.00%> (-34.62%) ⬇️
... and 878 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd7955...08346dd. Read the comment docs.

@lobkovilya lobkovilya merged commit 52acd1f into master Jun 28, 2021
@lobkovilya lobkovilya deleted the fix/zone-ingress-insight branch June 28, 2021 08:09
mergify bot pushed a commit that referenced this pull request Jun 28, 2021
(cherry picked from commit 52acd1f)

# Conflicts:
#	api/mesh/v1alpha1/zoneingress_overview.pb.go
lobkovilya added a commit that referenced this pull request Jun 28, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	api/mesh/v1alpha1/zoneingress_overview.pb.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal ZoneIngress is showing offline in gui
3 participants