chore(*) generate DeepCopy interfaces #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
+ Coverage 51.77% 52.05% +0.28%
==========================================
Files 909 895 -14
Lines 41004 41041 +37
==========================================
+ Hits 21229 21364 +135
+ Misses 17741 17619 -122
- Partials 2034 2058 +24
Continue to review full report at Codecov.
|
|
@jakubdyszkiewicz WDTY about this approach? |
Enable DeepCopy interface generation for Kubernetes resources. This takes advantage of the fact that if a type already implementes the DeepCopy interface, deepcopy-gen will use it. This means that we can wrap the raw protbuf message fields in a type that supports the interface and then generate everything else. This updates #2130. Signed-off-by: James Peach <james.peach@konghq.com>
|
I'm ok with this. The bigger win here would be to do scaffolding for the whole policy with API, kumactl, K8S etc. etc., but that requires a couple of orders magnitude more effort than this. |
jakubdyszkiewicz
approved these changes
Jul 5, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2021
Enable DeepCopy interface generation for Kubernetes resources. This takes advantage of the fact that if a type already implementes the DeepCopy interface, deepcopy-gen will use it. This means that we can wrap the raw protbuf message fields in a type that supports the interface and then generate everything else. This updates #2130. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fb4d537) # Conflicts: # mk/generate.mk
Yep, that would be great. I think we can get there, but baby steps :) |
bartsmykla
pushed a commit
that referenced
this pull request
Jul 5, 2021
Enable DeepCopy interface generation for Kubernetes resources. This takes advantage of the fact that if a type already implementes the DeepCopy interface, deepcopy-gen will use it. This means that we can wrap the raw protbuf message fields in a type that supports the interface and then generate everything else. This updates #2130. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fb4d537) # Conflicts: # mk/generate.mk
jpeach
added a commit
that referenced
this pull request
Jul 6, 2021
Enable DeepCopy interface generation for Kubernetes resources. This takes advantage of the fact that if a type already implementes the DeepCopy interface, deepcopy-gen will use it. This means that we can wrap the raw protbuf message fields in a type that supports the interface and then generate everything else. This updates #2130. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fb4d537)
jpeach
added a commit
that referenced
this pull request
Jul 6, 2021
Enable DeepCopy interface generation for Kubernetes resources. This takes advantage of the fact that if a type already implementes the DeepCopy interface, deepcopy-gen will use it. This means that we can wrap the raw protbuf message fields in a type that supports the interface and then generate everything else. This updates #2130. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fb4d537) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable DeepCopy interface generation for Kubernetes resources. This takes
advantage of the fact that if a type already implementes the DeepCopy
interface, deepcopy-gen will use it. This means that we can wrap the
raw protbuf message fields in a type that supports the interface and
then generate everything else.
This updates #2130.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing