Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp) add sha256 hash for mesh hash as well #2230

Merged
merged 1 commit into from
Jun 28, 2021
Merged

feat(kuma-cp) add sha256 hash for mesh hash as well #2230

merged 1 commit into from
Jun 28, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

A follow up for #2214

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@lobkovilya
feat(kuma-cp) add sha256 hash for mesh hash as well
d95b2d5 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner June 28, 2021 09:15
@codecov-commenter
Copy link

Codecov Report

Merging #2230 (d95b2d5) into master (11eab84) will increase coverage by 0.34%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   51.67%   52.01%   +0.34%     
==========================================
  Files         899      912      +13     
  Lines       40752    40997     +245     
==========================================
+ Hits        21057    21324     +267     
+ Misses      17674    17618      -56     
- Partials     2021     2055      +34
Impacted Files Coverage Δ
api/mesh/v1alpha1/dataplane.pb.go 36.83% <0.00%> (-0.24%) ⬇️
...p/kumactl/pkg/resources/service_overview_client.go 0.00% <0.00%> (ø)
app/kumactl/pkg/resources/zone_overview_client.go 0.00% <0.00%> (ø)
...mactl/pkg/resources/zoneingress_overview_client.go 0.00% <0.00%> (ø)
pkg/kds/context/context.go 44.11% <0.00%> (-2.76%) ⬇️
pkg/kds/global/components.go 17.30% <ø> (ø)
pkg/kds/zone/components.go 22.41% <ø> (ø)
...pi/v1alpha1/zone_ingress_insight_types_deepcopy.go 0.00% <0.00%> (ø)
...rces/k8s/native/api/v1alpha1/zone_insight_types.go 100.00% <ø> (ø)
test/e2e/hybrid/kuma_hybrid.go 0.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776523f...d95b2d5. Read the comment docs.

@lobkovilya lobkovilya merged commit 741afb8 into master Jun 28, 2021
@lobkovilya lobkovilya deleted the feat/sha256-hash branch June 28, 2021 10:07
mergify bot pushed a commit that referenced this pull request Jun 28, 2021
@lobkovilya
feat(kuma-cp) add sha256 hash for mesh hash as well (#2230)
6e517ea 
(cherry picked from commit 741afb8)

# Conflicts:
#	pkg/xds/cache/cla/cache.go
@mergify mergify bot mentioned this pull request Jun 28, 2021
Merged
lobkovilya added a commit that referenced this pull request Jun 28, 2021
@lobkovilya
feat(kuma-cp) add sha256 hash for mesh hash as well (#2230)
1b02d88
lobkovilya pushed a commit that referenced this pull request Jun 28, 2021
@mergify
feat(kuma-cp) add sha256 hash for mesh hash as well (#2230) (#2232)
ad235ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lobkovilya @codecov-commenter @jakubdyszkiewicz