Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*) allow RC tags in the release tagging script #2241

Merged
merged 2 commits into from
Jul 2, 2021
Merged

fix(*) allow RC tags in the release tagging script #2241

merged 2 commits into from
Jul 2, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 28, 2021

Summary

Update the release tagging script to allow an optional qualifier string
after a hyphen.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

$ ./tools/releases/make-release-tag.sh 1.2.0 v9.9.0-rc1
Created tag 'v9.9.0-rc1'.
Testing whether tag 'v9.9.0-rc1' can be pushed.
To github.com:kumahq/kuma.git
 * [new tag]           v9.9.0-rc1 -> v9.9.0-rc1
Run 'git push origin v9.9.0-rc1' to push the tag if you are happy.

$ git show v9.9.0-rc1 | head
tag v9.9.0-rc1
Tagger: James Peach <james.peach@konghq.com>
Date:   Tue Jun 29 07:56:15 2021 +1000

Tag v9.9.0-rc1 release.

Bart Smykla (4):
      chore(kuma-cp) new version of gui (#2187)
      fix(kuma-cp) supported versions fix (#2193)
      chore(kuma-cp) new gui version (#2219)

Update the release tagging script to allow an optional qualifier string
after a hyphen.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner June 28, 2021 21:57
Signed-off-by: James Peach <james.peach@konghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2241 (800effd) into master (3ee310d) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2241      +/-   ##
==========================================
+ Coverage   51.75%   52.04%   +0.29%     
==========================================
  Files         909      913       +4     
  Lines       41000    41036      +36     
==========================================
+ Hits        21218    21356     +138     
+ Misses      17745    17621     -124     
- Partials     2037     2059      +22     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 80.28% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/internal/util/proto/types.go 50.00% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.94% <0.00%> (+1.30%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 81.57% <0.00%> (+1.31%) ⬆️
api/mesh/v1alpha1/dataplane_helpers.go 78.08% <0.00%> (+1.68%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 79.22% <0.00%> (+2.59%) ⬆️
pkg/mads/v1/client/client.go 43.66% <0.00%> (+2.81%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee310d...800effd. Read the comment docs.

@jpeach
Copy link
Contributor Author

jpeach commented Jul 2, 2021

@lobkovilya Updated and ready for review :)

@jakubdyszkiewicz jakubdyszkiewicz merged commit 8b3e48b into kumahq:master Jul 2, 2021
mergify bot pushed a commit that referenced this pull request Jul 2, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 8b3e48b)
jakubdyszkiewicz pushed a commit that referenced this pull request Jul 2, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach deleted the fix/release-tagging-rc branch July 4, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants