fix(kuma-cp) resolve status problem without a corner case #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is showing us what will happen when global zone cp will die and before it will be back again if remote zone will die too it should reflect the zone status (offline) Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
==========================================
+ Coverage 51.77% 51.99% +0.21%
==========================================
Files 909 914 +5
Lines 41004 41134 +130
==========================================
+ Hits 21229 21386 +157
+ Misses 17741 17686 -55
- Partials 2034 2062 +28
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Jun 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
(cherry picked from commit cef8cda)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Jun 30, 2021
(cherry picked from commit cef8cda) Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves the same problem as #2245, but doesn't take into account corner case when Dataplane goes down while Control Plane is down.
Full changelog
Issues resolved
#1737
Documentation
Testing