feat(kuma-cp) Add datadog traffic tracing #2247

parkanzky · 2021-06-29T20:40:29Z

Signed-off-by: Paul Parkanzky paul.parkanzky@konghq.com

Summary

Add support for traffic tracing via Datadog.

Full changelog

Implement Datadog traffic tracing support

Testing

Unit tests
E2E tests
Manual testing on Universal
Manual testing on Kubernetes

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

codecov-commenter · 2021-06-29T21:14:30Z

Codecov Report

Merging #2247 (aac07f9) into master (3596f27) will increase coverage by 0.21%.
The diff coverage is 30.46%.

@@            Coverage Diff             @@
##           master    #2247      +/-   ##
==========================================
+ Coverage   51.77%   51.99%   +0.21%     
==========================================
  Files         909      913       +4     
  Lines       41004    41125     +121     
==========================================
+ Hits        21229    21382     +153     
+ Misses      17741    17681      -60     
- Partials     2034     2062      +28

Impacted Files	Coverage Δ
pkg/xds/generator/tracing_proxy_generator.go	`39.21% <0.00%> (-27.46%)`	⬇️
api/mesh/v1alpha1/mesh.pb.go	`31.66% <24.24%> (-0.72%)`	⬇️
pkg/core/resources/apis/mesh/mesh_validator.go	`83.20% <31.25%> (-8.77%)`	⬇️
pkg/xds/generator/inbound_proxy_generator.go	`70.78% <50.00%> (ø)`
pkg/xds/envoy/listeners/v3/tracing_configurer.go	`66.66% <70.00%> (+1.44%)`	⬆️
pkg/xds/envoy/listeners/configurers.go	`95.48% <100.00%> (+0.02%)`	⬆️
pkg/xds/generator/outbound_proxy_generator.go	`79.20% <100.00%> (ø)`
pkg/kds/client/sink.go	`43.58% <0.00%> (-5.13%)`	⬇️
pkg/mads/v1/client/client.go	`40.84% <0.00%> (-2.82%)`	⬇️
api/observability/v1/mads.pb.go	`34.64% <0.00%> (-1.31%)`	⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3596f27...aac07f9. Read the comment docs.

pkg/xds/generator/tracing_proxy_generator.go

api/mesh/v1alpha1/mesh.proto

api/DEVELOPER.md

pkg/xds/envoy/listeners/configurers.go

api/mesh/v1alpha1/mesh.proto

pkg/test/xds/client/go.mod

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

jakubdyszkiewicz

Please do not remove docs part from PR template.
It's important we don't forget about docs. If there are no docs for given PR, just mark the checkbox and write that there are no docs

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

* feat(kuma-cp) Add datadog traffic tracing Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kuma-cp) Address datadog integration PR comments Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kuma-cp) Fix tracing perspective Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit ba6bebe) # Conflicts: # api/mesh/v1alpha1/mesh.pb.go

jakubdyszkiewicz · 2021-07-02T09:38:44Z

Why did we merge it? We need to support Unix socket in order to support APM on Kubernetes.

* feat(kuma-cp) Add datadog traffic tracing Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kuma-cp) Address datadog integration PR comments Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kuma-cp) Fix tracing perspective Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

* feat(kuma-cp) add datadog traffic tracing (#2247) * feat(kuma-cp) Add datadog traffic tracing Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kuma-cp) Address datadog integration PR comments Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * feat(kuma-cp) Fix tracing perspective Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kuma-cp) Merge conflict requied pb re-generate Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> Co-authored-by: parkanzky <42279121+parkanzky@users.noreply.github.com> Co-authored-by: Paul Parkanzky <paul.parkanzky@konghq.com> Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

feat(kuma-cp) Add datadog traffic tracing

9ea5a04

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

parkanzky requested a review from a team as a code owner June 29, 2021 20:40

Merge branch 'master' into feat/datadog-integration

3e7fea8

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>