chore(kuma-dp) refactor dataplane resource loading #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the dataplane resource loading to make it oblivious to the underlying resource types. This will later allow us to add support for more dataplane resource types without changing any code. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2252 +/- ##
==========================================
+ Coverage 51.77% 52.05% +0.28%
==========================================
Files 909 913 +4
Lines 41004 41051 +47
==========================================
+ Hits 21229 21371 +142
+ Misses 17741 17621 -120
- Partials 2034 2059 +25
Continue to review full report at Codecov.
|
lobkovilya
approved these changes
Jun 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2021
Refactor the dataplane resource loading to make it oblivious to the underlying resource types. This will later allow us to add support for more dataplane resource types without changing any code. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit b2e7522) # Conflicts: # app/kuma-dp/cmd/run.go
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
Refactor the dataplane resource loading to make it oblivious to the underlying resource types. This will later allow us to add support for more dataplane resource types without changing any code. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit b2e7522)
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
Refactor the dataplane resource loading to make it oblivious to the underlying resource types. This will later allow us to add support for more dataplane resource types without changing any code. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit b2e7522) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the dataplane resource loading to make it oblivious to
the underlying resource types. This will later allow us to add
support for more dataplane resource types without changing any
code.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing