Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) fix hds disabled on dpserver #2268

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

bchatelard
Copy link
Contributor

Hds would be globally disabled on the dpserver when bootstraping a zone-ingress

Summary

Hds would be globally disabled on the dpserver when bootstraping a zone-ingress

Full changelog

  • fix(kuma-cp) fix hds disabled on dpserver

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@bchatelard bchatelard requested a review from a team as a code owner July 1, 2021 16:14
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2021

CLA assistant check
All committers have signed the CLA.

@bchatelard bchatelard force-pushed the fix-hds-disabled-by-zone-ingress branch from 3724f38 to a91ca88 Compare July 1, 2021 16:27
Hds would be globally disabled on the dpserver when bootstraping a zone-ingress

Signed-off-by: Bastien Chatelard <bastien@koyeb.com>
@bchatelard bchatelard force-pushed the fix-hds-disabled-by-zone-ingress branch from a91ca88 to 958d8f7 Compare July 1, 2021 16:30
@codecov-commenter
Copy link

Codecov Report

Merging #2268 (958d8f7) into master (08ffede) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
+ Coverage   51.66%   52.01%   +0.35%     
==========================================
  Files         910      914       +4     
  Lines       41116    41154      +38     
==========================================
+ Hits        21242    21407     +165     
+ Misses      17838    17685     -153     
- Partials     2036     2062      +26     
Impacted Files Coverage Δ
pkg/xds/bootstrap/generator.go 62.33% <100.00%> (+0.76%) ⬆️
pkg/plugins/runtime/universal/outbound/outbound.go 62.50% <0.00%> (-1.79%) ⬇️
api/internal/util/proto/types.go 50.00% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.94% <0.00%> (+1.30%) ⬆️
pkg/core/resources/model/rest/resource.go 66.66% <0.00%> (+1.51%) ⬆️
api/mesh/v1alpha1/dataplane_helpers.go 77.84% <0.00%> (+1.70%) ⬆️
pkg/mads/v1/client/client.go 43.66% <0.00%> (+2.81%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ffede...958d8f7. Read the comment docs.

Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch! Thank you!

@lobkovilya lobkovilya merged commit b3e0498 into kumahq:master Jul 2, 2021
mergify bot pushed a commit that referenced this pull request Jul 2, 2021
Hds would be globally disabled on the dpserver when bootstraping a zone-ingress

Signed-off-by: Bastien Chatelard <bastien@koyeb.com>
(cherry picked from commit b3e0498)
jakubdyszkiewicz pushed a commit that referenced this pull request Jul 5, 2021
Signed-off-by: Bastien Chatelard <bastien@koyeb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants